git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Extend t6020 with another test for d/f interactions

From
Alex Riesen <raa.lkml@gmail.com>
Date
Sep 18, 2007, 22:12 UTC
Message-ID
<20070918221208.GB14488@steel.home>
In-Reply-To
<95b3d0af0709181334y1e21507ey485860e4d45aa26f@mail.gmail.com>

A test for a merge when one of the trees has a file moved into a directory with the same name (not just file replaced by a directory).

The problem noticed and reported by David Euresti
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---
 t/t6020-merge-df.sh |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)
David Euresti, Tue, Sep 18, 2007 22:34:53 +0200:
Show 6 quoted lines
> If I try to merge in the changes from the other branch or if the other
> branch tries to merge in these changes I get this error:
> 
> dir/foo/foo.bin: unmerged (257cc5642cb1a054f08cc83f2d943e56fd3ebe99)
> fatal: git-write-tree: error building trees
> Merge with strategy recursive failed.

I extended the d/f merge test with the case. Have no idea how to fix it yet though.

diff --git a/t/t6020-merge-df.sh b/t/t6020-merge-df.sh
index a19d49d..c081d3f 100755
--- a/t/t6020-merge-df.sh
+++ b/t/t6020-merge-df.sh
@@ -10,6 +10,7 @@ test_expect_success 'prepare repository' \
 'echo "Hello" > init &&
 git add init &&
 git commit -m "Initial commit" &&
+git branch init &&
 git branch B &&
 mkdir dir &&
 echo "foo" > dir/foo &&
@@ -22,4 +23,20 @@ git commit -m "File: dir"'
 
 test_expect_code 1 'Merge with d/f conflicts' 'git merge "merge msg" B master'
 
+test_expect_success 'file moved into a dir of same name' '
+    git reset --hard &&
+    git checkout -b d1 init &&
+    mkdir dir &&
+    mv init dir/init &&
+    mv dir init &&
+    git add . &&
+    git commit -a -m"init moved into init/init" &&
+    git checkout -b d2 init &&
+    echo file >file &&
+    git add file &&
+    git commit -m"unrelated change" &&
+    git checkout d1 &&
+    git merge d2
+'
+
 test_done
-- 
1.5.3.1.173.g9a67
Previous: David EurestiNext: Junio C Hamano
Message 2 of 7 in “Problem with merge when renaming”
  1. David EurestiSep 18, 2007
  2. Extend t6020 with another test for d/f interactionsAlex Riesen, Sep 18, 2007
  3. Junio C HamanoSep 18, 2007
  4. David EurestiSep 18, 2007
  5. Alex RiesenSep 18, 2007
  6. Junio C HamanoSep 18, 2007
  7. Alex RiesenSep 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.