Re: [PATCH 2/2] git-commit: Add --no-status option
- From
Alex Riesen <raa.lkml@gmail.com>
- Date
- Sep 6, 2007, 22:15 UTC
- Message-ID
- <20070906221557.GA20575@steel.home>
- In-Reply-To
- <20070905234953.GB643@nomad.office.altlinux.org>
Dmitry V. Levin, Thu, Sep 06, 2007 01:49:53 +0200:
> By default, git-commit runs git-runstatus to print changes between > the index and the working tree. This operation is very costly and > is not always necessary. New option allows user to commit without > running git-runstatus when appropriate.
Not a very good name for the option. Noone, except for a few, knows that git-commit runs runstatus. The name makes no sense.
"git-commit --index", perhaps (the current state of index to be commited). Or "git-commit --prepared" (the commit is prepared and there can be stored immediately). Even a dumb "--fast" would be better (because it is the purpose of the patch).
Besides, now when you disabled runstatus, you better check for changes in the index with something like "git diff --quiet --cached".