Re: [PATCH 00/15] i18n support for git-gui
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Sep 3, 2007, 04:49 UTC
- Message-ID
- <20070903044938.GQ18160@spearce.org>
- In-Reply-To
- <Pine.LNX.4.64.0709021738090.28586@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 6 quoted lines
> sorry for the fsckup with the first two patches; both should be attributed > to Christian Stimming. > > For convenience, I also uploaded that patch series (on top of your > "git-gui: Initialize Tcl's msgcat library for internationalization" in > your "pu" branch) to the "for-shawn" branch in git-gui-i18n.
That was *much* easier than the small patch bomb. ;-)
I've swallowed this series down and added it to my `master` branch. I found one bug in the [mc "..."] string definitions and fixed it (below). I also applied Michele Ballabio's "remove does in some UI strings" patch on top. Those two changes I'm sure will impact some of the translated strings. I guess someone needs to run `make update-po` and ask translators to revise the individual languages?
-->8-- From b86882eda026a0da18472587034250a53e0daf51 Mon Sep 17 00:00:00 2001 From: Shawn O. Pearce <spearce@spearce.org> Date: Mon, 3 Sep 2007 00:22:19 -0400 Subject: [PATCH] git-gui: Correct stock message for 'Invalid font specified in %s'
This particular message is talking about a specific option in the configuration file named "gui.$name". This option is not localized so we cannot localize the "gui." that denotes the section the option $name is found within. Currently there are no plans to localize the configuration options for git-gui, but if that were to change in the future then it would be necessary to localize not only the "gui." section prefix but also the $name (fontui and fontdiff).
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- git-gui.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh index 913ba68..5635eea 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -1643,7 +1643,7 @@ proc apply_config {} { font configure $font $cn $cv } } err]} { - error_popup [append [mc "Invalid font specified in gui.%s:" $name] "\n\n$err"] + error_popup [append [mc "Invalid font specified in %s:" "gui.$name"] "\n\n$err"] } foreach {cn cv} [font configure $font] { font configure ${font}bold $cn $cv
-- 1.5.3 -- Shawn.