git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix file name quoting in simplified out patch detection for --cc output

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 2, 2007, 20:22 UTC
Message-ID
<200709022222.13865.jnareb@gmail.com>

For the --cc (compressed combined) diff output there can be patches which are simple and got simplified out, so there is no patch corresponding to raw output line.

Fix detection of of such simplified out patches: file name in git diff header for --cc diff can be quoted; unquote it.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This patch depends _textually_ on the just send
  "gitweb: Fix and simplify "split patch" detection"
patch, although it is _conceptually_ independent.
The commit message could be better...
 gitweb/gitweb.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 8c1e02c..5d424e5 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3140,8 +3140,8 @@ sub git_patchset_body {
 			# compact combined diff output can have some patches skipped
 			# find which patch (using pathname of result) we are at now
 			my $to_name;
-			if ($patch_line =~ m!^diff --cc "?(.*)"?$!) {
-				$to_name = $1;
+			if ($patch_line =~ m!^diff --cc ("?.*"?)$!) {
+				$to_name = unquote($1);
 			}
 
 			do {
-- 
1.5.2.5
Next: Junio C Hamano
Message 1 of 3 in “gitweb: Fix file name quoting in simplified out patch detection for --cc output”
  1. gitweb: Fix file name quoting in simplified out patch detection for --cc outputJakub Narebski, Sep 2, 2007
  2. Junio C HamanoSep 3, 2007
  3. Jakub NarebskiSep 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.