Re: git svn dcommit not checking if up-to-date?

From: Eric Wong <normalperson@yhbt.net>
Date: Aug 31, 2007, 22:18 UTC
Message-ID: <20070831221814.GB31033@untitled>
In-Reply-To: <Pine.LNX.4.64.0708312200480.28586@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 14 quoted lines

> Hi Eric,
> 
> harningt just asked about known issues of git-svn on IRC, and I remembered 
> that I had an issue: Accidentally, I forgot to "git svn fetch" before "git 
> svn dcommit"ing, and unfortunately, a colleague had just checked in a 
> change, which got undone by my dcommit.
> 
> Is this a known issue, has it been fixed, am I a bad pilot?
> 
> Ciao,
> Dscho
> 
> P.S.: harningt promised to get his hands dirty, but I just realised that 
> the issue could be fixed since long ago...

I believe this was fixed a while back in commit 45bf473a7bc2c40c8aea3d34a0eab7a41e77a8ff (Thu Nov 9 01:19:37 2006 -0800).

I just tested this on a live server, and it seems to be correctly erroring out if the local files are not up-to-date.

The only currently known issues that could break commits is from using merge or pull from another svn branch and trying to dcommit the result (see CAVEATS section in the manpage). I hope to fix this soon (hoping somebody beats me to it, of course)

Otherwise there's still open bugs on svn:// fetch connections dying and permissions issues with some DAV repos, neither of which can cause data corruption on either side.

-- 
Eric Wong