git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [StGIT PATCH 4/4] Add optional logging of subprocess execution

From
Karl Hasselström <kha@treskal.com>
Date
Aug 29, 2007, 11:11 UTC
Message-ID
<20070829111102.GA29980@diana.vm.bytemark.co.uk>
In-Reply-To
<b0943d9e0708290350rbadfe08g9bbab7888723980e@mail.gmail.com>
On 2007-08-29 11:50:11 +0100, Catalin Marinas wrote:
Show 10 quoted lines
> On 26/08/2007, Karl Hasselström <kha@treskal.com> wrote:
>
> > Now that the subprocess calling has been refactored and is in a
> > nice shape, it's quite simple to add some logging facilities. This
> > patch adds two separate log modes, switched by the
> > STG_SUBPROCESS_LOG environment variable:
>
> Any objection to calling this variable STGIT_SUBPROCESS_LOG? We
> already have STGIT_DEBUG_LEVEL (used in stgit.main). I can do it in
> my tree before pushing as I already merged your branches.

No, no objection at all. I was simply too lazy to actually check what the existing naming convention was, and misremembered.

> BTW, thanks for refactoring the subprocess calling.
It needed doing, and was actually fun.

Any chance we can drop Python 2.3 support any time soon, by the way? I've confined all the ickyness to one place, but it would still be good to get rid of it (not to mention being able to use sets and generator expressions).

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Previous: Catalin MarinasNext: Karl Hasselström
Message 7 of 14 in “Clean up subprocess calling”
  1. 0/4 Clean up subprocess callingKarl Hasselström, Aug 26, 2007
  2. 1/4 Refactor output handling to break circular dependencyKarl Hasselström, Aug 26, 2007
  3. 2/4 Refactor subprocess creationKarl Hasselström, Aug 26, 2007
  4. 3/4 Assert that the argument to Run is a sequence of stringsKarl Hasselström, Aug 26, 2007
  5. 4/4 Add optional logging of subprocess executionKarl Hasselström, Aug 26, 2007
  6. Catalin MarinasAug 29, 2007
  7. Karl HasselströmAug 29, 2007
  8. Karl HasselströmAug 29, 2007
  9. Catalin MarinasSep 3, 2007
  10. Catalin MarinasSep 3, 2007
  11. Karl HasselströmSep 3, 2007
  12. 0/2 Break Python 2.3 compatibilityKarl Hasselström, Sep 3, 2007
  13. 1/2 Use subprocess.Popen to call git executablesKarl Hasselström, Sep 3, 2007
  14. 2/2 Use the builtin set() instead of sets.Set()Karl Hasselström, Sep 3, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.