Re: [PATCH 4/5] gitweb: Selecting diffs in JavaScript
- From
Petr Baudis <pasky@suse.cz>
- Date
- Aug 26, 2007, 01:17 UTC
- Message-ID
- <20070826011742.GF1219@pasky.or.cz>
- In-Reply-To
- <11796926122089-git-send-email-mkoegler@auto.tuwien.ac.at>
On Sun, May 20, 2007 at 10:23:31PM CEST, Martin Koegler wrote:
> The adds support for selecting arbitrary diffs, if the client browser supports > JavaScript. > > Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
JFYI, I've just enabled it on repo.or.cz experimentally. Please anyone tell me what you think.
(Just click at almost any view in gitweb and marvel at the extra base and diff links smiling everywhere.)
I'll dump my mind state here, horribly sleepy. Sorry for the incomprehensible rant. :-)
One thing for certain is that I would get rid of GitAddLinks and instead have href() add the extra links there, by default display: none and javascript code making it show. Also, there are obvious UI bugs, like commit and tree entries for commits having redundant base/diff links; and Firefox doesn't expand table cells properly for the additional links. None of these bugs is easily fixable I think.
But maybe it needs more general overhaul and the links added explicitly in the views, because it really makes sense to have only a single linkpair per entry and it would be good to have this always at the same place, and perhaps in a different color. Hmm. And it seems that it's getting in the way, overally.
Hmm.
What about having another item in the main action menu, 'diff'? Base/diff links are by default display: none but show up when you click at 'diff', in green. They will keep showing up until you click 'diff' again. When you click 'base', both the selected base link and main 'diff' link changes color to red.
Oh the naivity that I've already lost about that someone might make a patch while I'm sleeping... ;-)
-- Petr "Pasky" Baudis Ever try. Ever fail. No matter. // Try again. Fail again. Fail better. -- Samuel Beckett