git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] gitweb: Lift any characters restriction on searched strings

From
Petr Baudis <pasky@suse.cz>
Date
Aug 25, 2007, 22:18 UTC
Message-ID
<20070825221847.11739.46741.stgit@rover>

Everything is already fully quoted along the way so I believe this to be unnecessary at this point. It would pose trouble for regexp searches.

Cc: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
 gitweb/gitweb.perl |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 677f4fb..1ac4523 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -476,9 +476,6 @@ if (defined $searchtype) {
 our $searchtext = $cgi->param('s');
 our $search_regexp;
 if (defined $searchtext) {
-	if ($searchtype ne 'grep' and $searchtype ne 'pickaxe' and $searchtext =~ m/[^a-zA-Z0-9_\.\/\-\+\:\@ ]/) {
-		die_error(undef, "Invalid search parameter");
-	}
 	if (length($searchtext) < 2) {
 		die_error(undef, "At least two characters are required for search parameter");
 	}
Next: Petr Baudis
Message 1 of 6 in “gitweb: Lift any characters restriction on searched strings”
  1. 1/2 gitweb: Lift any characters restriction on searched stringsPetr Baudis, Aug 25, 2007
  2. 2/2 gitweb: Clearly distinguish regexp / exact match searchesPetr Baudis, Aug 25, 2007
  3. gitweb: Clearly distinguish regexp / exact match searchesPetr Baudis, Aug 26, 2007
  4. Jakub NarebskiSep 1, 2007
  5. Jakub NarebskiAug 27, 2007
  6. Petr BaudisAug 27, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.