Re: [PATCH] Documentation: update tar.umask default

From: Mike Hommey <mh@glandium.org>
Date: Aug 21, 2007, 21:15 UTC
Message-ID: <20070821211526.GA12483@glandium.org>
In-Reply-To: <46CB286C.8000403@lsrfire.ath.cx>

On Tue, Aug 21, 2007 at 08:01:16PM +0200, René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:

Show 18 quoted lines

> As noted by Mike Hommey, the documentation for the config setting tar.umask
> is not up-to-date.  Commit f08b3b0e2e9ad87767d80ff03b013c686e08ba4b changed
> the default from 0 to 2; this patch finally documents it.
> 
> Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
> ---
> diff --git a/Documentation/git-archive.txt b/Documentation/git-archive.txt
> index 4da07c1..9984a11 100644
> --- a/Documentation/git-archive.txt
> +++ b/Documentation/git-archive.txt
> @@ -80,8 +80,8 @@ in the repository configuration as follows :
>          umask = 002	;# group friendly
>  
>  The special umask value "user" indicates that the user's current umask
> -will be used instead. The default value remains 0, which means world
> -readable/writable files and directories.
> +will be used instead.  The default is 002, which allows reading for all
> +and writing for both owner and group.

Actually, I'd say it's not enough ; users may be confused by the sentence just above:

By default, file and directories modes are set to 0666 or 0777 in tar archives.

Which is true, but if you are not very familiar with umask, you won't actually gather from the rest that the modes are not going to be that by default.

Mike