Re: [PATCH] Make git-prune submodule aware (and fix a SEGFAULT in the process)

From: Andy Parkins <andyparkins@gmail.com>
Date: Aug 17, 2007, 08:39 UTC
Message-ID: <200708170939.47214.andyparkins@gmail.com>
In-Reply-To: <200707021356.58553.andyparkins@gmail.com>

On Monday 2007, July 02, Andy Parkins wrote:

Show 5 quoted lines

> This repository was a strange one in that it was being used to provide
> its own submodule.  That is, the repository was cloned into a
> subdirectory, an independent branch checked out in that subdirectory,
> and then it was marked as a submodule.  git-prune then failed in the
> above manner.

I think I've stumbled on another place where this is happening. git-upload-pack is crashing for me with a similar "Object is commit not blob" error just before.

I'm happy to try and track it down, but I'm having difficulty because I think the crash is happening in the process on the remote system, so I'm not getting a core dump I can use.

Could any of the guru's give me a guide to upload-pack.c? I assume the problem is going to be the same as it was for git-prune, the hash for the gitlink object in the tree is being assumed to be an object in the ODB; which isn't the case with gitlink entries. Where would that be happening in git-upload-pack? The fix is going to be..

 if( S_ISGITLINK(mode))
      continue;

But I've got no idea where to put it :-)

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com