Re: [PATCH] git-submodule: re-enable 'status' as the default subcommand

From: Sven Verdoolaege <skimo@kotnet.org>
Date: Aug 17, 2007, 09:09 UTC
Message-ID: <20070817090947.GG1070MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <7vmywqh98d.fsf@gitster.siamese.dyndns.org>

On Sat, Aug 04, 2007 at 04:25:53PM +0200, Lars Hjemli wrote:

Show 20 quoted lines

> This was broken as part of ecda072380.
> 
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>  git-submodule.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 2cfeadd..3320998 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -313,7 +313,7 @@ case "$add,$init,$update,$status,$cached" in
>  ,,1,,)
>  	modules_update "$@"
>  	;;
> -,,,1,*)
> +,,,*,*)
>  	modules_list "$@"
>  	;;
>  *)

Sorry about that. I didn't realize that it was supposed to do that (it seems I didn't read the manual carefully enough) and I forgot to mention I changed it.

On Fri, Aug 17, 2007 at 01:10:42AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> "Lars Hjemli" <lh@elementstorage.no> writes:
> > I got no response on this patch, was it simply overlooked? I really think
> >
> > $ git submodule
> >
> > should show the available submodules and their status.
> 
> Probably.  I do not think of any other alternative behaviour
> that would make sense.
> 
> Sven?

No objections from me.

skimo