Re: msysgit: does git gui work?

From: Shawn O. Pearce <spearce@spearce.org>
Date: Aug 10, 2007, 05:31 UTC
Message-ID: <20070810053158.GJ24573@spearce.org>
In-Reply-To: <E886F099-5E9F-4785-A560-F9AAAA4E4C1F@zib.de>

Steffen Prohaska <prohaska@zib.de> wrote:

Show 15 quoted lines

> mingw only contains tclsh84 but not tclsh. This causes
> the Makefile in git-gui to fail on the creation of
> lib/tclIndex. Therefore git gui decides to take the slow
> path of sourcing the files in lib explicitly but this failes
> because they are sourced before git-version is defined.
> Therefore blame.tcl reports the error mentioned above.
> 
> Johannes (or someone else from the msysgit team),
> We should modify mingw to contain the symlink to tclsh.
> Or something similar, at least 'tclsh' should be there.
> 
> Shawn,
> The fallback mechanism of sourcing files from lib is broken.
> Either git-version must be defined before sourcing them, or
> the auto_index must always work.

*ouch*. Yea, that happened when the git-version proc was introduced. It doesn't get declared until after we have sourced everything, but the things we are sourcing want it to be declared.

The short-term workaround is the obvious thing of just making sure the auto_index works in the Makefile. I'll try to reorder things in git-gui so that the "source everything fallback" is done only after git-version is declared. Though that might be difficult as that codepath assumes error_popup has been declared and that's in something we are sourcing.

Ouch.

	me: Doctor, it hurts when I declare circular dependencies!
	dr: Well, don't do that son!

-- 
Shawn.