Re: Template commit messages.

From: Jan Hudec <bulb@ucw.cz>
Date: Aug 8, 2007, 16:24 UTC
Message-ID: <20070808162411.GA4884@efreet.light.src>
In-Reply-To: <18071eea0708050532x2d9bfddw96a9428f4840b1fc@mail.gmail.com>

On Sun, Aug 05, 2007 at 13:32:48 +0100, Thomas Adam wrote:

> Am I correct in thinking that the new template messages that will be
> in the up and coming git release will alleviate an "annoyance" I've
> currently got with commit messages?

Reading the description below, I really doubt that. The templates are to *add* stuff, not to remove it.

Show 6 quoted lines

> Basically, I want a way of removing what is now, a long list of
> untracked files from the commit message before it hits the editor --
> I've looked at $GIT_DIR/.git/hooks/{pre,post}-commit as well as:
> $GIT_DIR/.git/hooks/commit-msg in the hopes I could add  a sed command
> there to remove the list of files, and whilst the sed command worked
> fine on the command line, adding it to any of those files didn't.

Neither of this commands actually see the list. Because the list is *not* part of the commit message. It is a comment, which is added just before the editor is started and stripped right afterwards.

Show 12 quoted lines

> Was this even the right approach?  I didn't want to go messing with
> git-commit, frankly, so I am hoping that these new templates might
> just do the trick.
> 
> You might ask why I've got such a large list of untracked files -- the
> reason is because I use the same repository to build files in, which
> themselves have no need to be added.  And whilst I can catch some of
> these instances by using .gitignore, it's not enough since not all of
> the files have a common extension or anything.  And whilst I realise
> the list of untracked file is just a friendly warning to me, I find it
> annoying and would rather it didn't appear at all if possible, since I
> know myself which files need explicitly adding.  :)

a) The files don't need a common anything to be ignored with .gitignore. It
   is a list of patterns, so you can list the names. Of course not suitable
   if the names change or there is really a huge amount of them.
b) There is actually no problem in tracking files that match ignore pattern,
   as it is only applied to files that don't appear in index. That gives you
   the option to simply ignore '*' (and live with the minor annoyance that
   you have to add -f to add command line -- git commit -a and git add -u
   will include changes in tracked files all right).
c) Consider changing the build process to put the built files in
   a subdirectory, if you have a chance. In my experience it not only helps
   keeping track whether everything is versioned that should be, but also
   helps navigating the tree (no uninteresting files interfering with shell
   completion/cluttering file selection dialogs) and offer easy way to do
   a clean build when you suspect the build might have screwed up somewhere
   (just delete the directory).

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>