[PATCH] post-receive-email hook: handle order of arguments consistently
- From
Gerrit Pape <pape@smarden.org>
- Date
- Aug 7, 2007, 13:58 UTC
- Message-ID
- <20070807135849.24926.qmail@49810ee852ce6e.315fe32.mid.smarden.org>
- In-Reply-To
- <200706141119.18724.andyparkins@gmail.com>
The post-receive-email hook usually gets its arguments through stdin, but also supports them to be specified at the command line. The order of the arguments should consistently follow the documentation no matter how they are passed to the script.
This was noticed and suggested by martin f krafft through http://bugs.debian.org/428413
Signed-off-by: Gerrit Pape <pape@smarden.org> ---
On Thu, Jun 14, 2007 at 11:19:17AM +0100, Andy Parkins wrote:
Show 12 quoted lines
> On Thursday 2007 June 14, Gerrit Pape wrote: > > The post-receive-email hook usually gets its arguments through stdin, but > > also supports them to be specified at the command line. The order of the > > arguments should consistently follow the documentation no matter how they > > are passed to the script. > > That wasn't done casually. It was done so that the same script would work as > an update hook as well. > > I have no objection to the change, as the update hook was not the right place > for generating emails. However, it let me use that same update hook on a > system that did not have a git with support for the post-receive hook.
Hi, I suggest to apply this patch for 1.5.3. Thanks, Gerrit.
contrib/hooks/post-receive-email | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index c589a39..f84532f 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -605,7 +605,7 @@ envelopesender=$(git-repo-config hooks.envelopesender) if [ -n "$1" -a -n "$2" -a -n "$3" ]; then # Output to the terminal in command line mode - if someone wanted to # resend an email; they could redirect the output to sendmail themselves - PAGER= generate_email $2 $3 $1 + PAGER= generate_email $1 $2 $3 else if [ -n "$envelopesender" ]; then envelopesender="-f '$envelopesender'"
-- 1.5.3.GIT