Re: [PATCH] git-clone: use cpio's --quiet flag

From: Jeff King <peff@peff.net>
Date: Aug 5, 2007, 09:36 UTC
Message-ID: <20070805093645.GD12507@coredump.intra.peff.net>
In-Reply-To: <7v4pjefkdu.fsf@assigned-by-dhcp.cox.net>

On Sun, Aug 05, 2007 at 01:36:29AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> > I see, though the hardlink warning is a bit much.
> >
> > $ git-clone /path/on/fs/one /path/on/fs/two
> > Initialized empty Git repository in /path/on/fs/two/.git/
> > Warning: -l asked but cannot hardlink to /path/on/fs/one/.git
> > 36634 blocks
> 
> True; -l is not given explicitly in your example.  Should be
> trivial to fix.

Ah, indeed, I had assumed that it came from cpio (which also uses the -l flag!), but reading the code, it's us. Given that "-l" is now the default, and we silently downgrade to copying anyway, I don't see the point of having any warning at all. Unless, I guess, for those people who are still using "-l" even though it's a noop.

-Peff