Re: (Resend)[PATCH] git-svn: Translate invalid characters in refname

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 30, 2007, 19:29 UTC
Message-ID: <20070730192929.GB9764@hand.yhbt.net>
In-Reply-To: <7v6442kxvu.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Robert Ewald <robert.ewald@nov.com> writes:
> 
> > +sub refname {
> > +        my ($refname) = "refs/remotes/$_[0]->{ref_id}" ;
> > +
> > +        # It cannot end with a slash /, we'll throw up on this because
> > +        # SVN can't have directories with a slash in their name, either:
> > +        if ($refname =~ m{/$}) {
> > +                die "ref: '$refname' ends with a trailing slash, this is ",
> > +                    "not permitted by git nor Subversion\n";
> > +        }
> > +
> > +        # It cannot have ASCII control character space, tilde ~, caret ^,
> > +        # colon :, question-mark ?, asterisk *, space, or open bracket [
> > +        # anywhere.
> > +        #
> > +        # Additionally, % must be escaped because it is used for escaping
> > +        # and we want our escaped refname to be reversible
> > +        $refname =~ s{([ \%~\^:\?\*\[\t])}{uc sprintf('%%%02x',ord($1))}eg;
> 
> uc of sprintf()?  You meant "%%%02X"?

Ah, I wasn't sure if X was portable enough, but then again this sprintf is in Perl.

> Other than that, looks sane to me.  I presume that SVN branches
> whose name would be mangled with this patch would not have been
> successfully imported with older git-svn anyway, so this won't
> introduce any regressions?

Seems alright to me, I haven't had a chance to look at it too hard. I'm out of town and haven't been following the mailing list lately.

Acked-by: Eric Wong <normalperson@yhbt.net>

-- 
Eric Wong