Re: git-gui ignores core.excludesFile
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Jul 29, 2007, 07:22 UTC
- Message-ID
- <20070729072247.GM20052@spearce.org>
- In-Reply-To
- <20070723150700.GA17167@lars.home.noschinski.de>
Lars Noschinski <lars@public.noschinski.de> wrote:
Show 8 quoted lines
> It seems git-gui (0.7.5 from git 1.5.2.4 tarball) ignores the global > ignore file configured with the core.excludesfile option. My > ~/.gitconfig contains > > [core] > excludesFile = /home/noschinski/.gitignore > > which is honoured by git-status but not by git-gui.
Whoops. Thanks. git-gui 0.8.0 will include the following patch:
-->8-- From 94a4dd9bfda79a226f8dd57fd20c39c6603ec194 Mon Sep 17 00:00:00 2001 From: Shawn O. Pearce <spearce@spearce.org> Date: Sun, 29 Jul 2007 03:22:27 -0400 Subject: [PATCH] git-gui: Honor core.excludesfile when listing extra files
Recent git versions have a git-status that honors the core.excludesfile configuration option when it reports on untracked files. Unfortunately I missed the introduction of this configuration option in the core porcelain implementation, so it was not reflected here in git-gui.
Found and reported by Lars Noschinski <lars@public.noschinski.de>.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org> --- git-gui.sh | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh index d7fad46..4e3b58c 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -872,6 +872,10 @@ proc rescan_stage2 {fd after} { if {[file readable $info_exclude]} { lappend ls_others "--exclude-from=$info_exclude" } + set user_exclude [get_config core.excludesfile] + if {$user_exclude ne {} && [file readable $user_exclude]} { + lappend ls_others "--exclude-from=$user_exclude" + } set buf_rdi {} set buf_rdf {}
-- 1.5.3.rc3.843.g25b4 -- Shawn.