Re: [ANNOUNCE]: PyGit and libgit-thin

From: Yann Dirson <ydirson@altern.org>
Date: Jul 25, 2007, 19:50 UTC
Message-ID: <20070725195010.GA30277@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <e28f90730707230535q33658efevf665d795cf1df87c@mail.gmail.com>

On Mon, Jul 23, 2007 at 09:35:47AM -0300, Luiz Fernando N. Capitulino wrote:

> Now I need to know whether this' really useful to other people and
> if so, what would be missing for you to start using it.

The python module would really be useful to StGIT. Currently, an stgit commands typically has to fork several git commands at least, and using library calls instead would surely help with the performance.

I had a quick look at the current pygit API (as described in the README), and I find the current revlist one somewhat confusing. Why using post-contructor methods, and not using named args in the constructor itself ?

That is, the example reading:

Show 5 quoted lines

>>> rv = repo.revlist()
>>> rv.include('8d9107e8c50e1c4ff43c91c8841805833f3ecfb9')
>>> rv.count = 10
>>> rv.show_merges()
>>> for commit in rv:

... print commit.id() ...

would be IMHO much nicer to use as:

>>> rv = repo.revlist(include=('8d9107e8c50e1c4ff43c91c8841805833f3ecfb9'),

... count = 10, ... show_merges = true) ...

>>> for commit in rv:

... print commit.id() ...

What do you think ?

Best regards,

-- 
Yann