Re: [PATCH] Fix translation of strings in foreach lists.
Christian Stimming <stimming@tuhh.de> wrote:
Show 10 quoted lines
> Fix translation of strings in foreach lists.
>
> Signed-off-by: Christian Stimming <stimming@tuhh.de>
> ---
> Quoting Brett Schwarz <brett_schwarz@yahoo.com>:
> >I not sure if it's worth changing, but you don't necessarily need
> >those [append]'s in there.
>
> Thanks for the info. It is basically up to Shawn to decide which style
> he likes more.
"[mc Foo]\n\n$err"
is much shorter. So I'd prefer that over [append [mc Foo] "\n\n$err"].
Its not like you've saved a dq-eval either, as you still have to do one
for the \n\n. But either way is valid Tcl, and works, and the append
version is not so bad that I'd reject a patch that used it.
--
Shawn.
Shawn O. Pearce <spearce@spearce.org>