Re: [RFC] describe: add option --dirty

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 23, 2007, 07:58 UTC
Message-ID: <20070723075834.GK32566@spearce.org>
In-Reply-To: <87lkd7mu71.wl@mail2.atmark-techno.com>

Yasushi SHOJI <yashi@atmark-techno.com> wrote:

Show 22 quoted lines

> From the comments I'd add an option "--workinig-tree" instead of
> --dirty to describe the working tree.  because that, the special case,
> is what we want after all,
> 
> synopsis would be:
> 
> 	SYNOPSIS
> 	--------
> 	'git-describe' [--all] [--tags] [--contains] [--abbrev=<n>]
> 	               [--candidates=<n>] [--debug]
> 	               --working-tree | <committish>...
> 	    :
> 	    :
> 	--working-tree::
> 		Describe the working tree instead of committishes.  if the
> 		working tree is dirty, the describe string will have "-dirty"
> 		appended.
> 	
> 		As you can assume from the name, this option requires working
> 		tree; running it on a bare repository will fail.
> 
> what do you think?

That's reasonable. It seems like a lot of work in core Git just to avoid a small chunk of shell, but I think almost everyone has that same small chunk of shell in their build scripts...

-- 
Shawn.