Re: Test #7 in t9200-git-cvsexportcommit fails

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jul 22, 2007, 21:42 UTC
Message-ID: <20070722214224.GA2732@steel.home>
In-Reply-To: <31e9dd080707221349g40ff050bue72733f270822603@mail.gmail.com>

Jason Sewall, Sun, Jul 22, 2007 22:49:19 +0200:

Show 8 quoted lines

> >It'll never work, cvs does not commit changes made during one second,
> >as they have the same timestamp.
> 
> Why not add a delay in there, like this:
> 
> id=$(git rev-list --max-count=1 HEAD) && sleep 2
> 
> It makes the test work for me.

It looks just like another reason to disable it. It is not like the _git_ functionality which is used by git-cvsexportcommit is not already tested elsewhere.

Note that I do _NOT_ suggest disabling it by default, but a bit of warning would probably do some good:

diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
index 4efa0c9..e5e9e36 100755
--- a/t/t9200-git-cvsexportcommit.sh
+++ b/t/t9200-git-cvsexportcommit.sh
@@ -6,6 +6,12 @@ test_description='CVS export comit. '
 
 . ./test-lib.sh
 
+echo >&2
+echo >&2 "This test is very timing dependent and may fail."
+echo >&2 "If you don't need git-cvsexportcommit you're better off"
+echo >&2 "disabling it: make test GIT_SKIP_TESTS=t9200"
+echo >&2
+
 cvs >/dev/null 2>&1
 if test $? -ne 1
 then