Re: [PATCH] git-svn: Minimalistic patch which allows svn usernames with space(s).
Eric Wong <eric@petta-tech.com> wrote:
Show 23 quoted lines
> Richard MUSIL <richard.musil@st.com> wrote:
> > Changed filter for username in svn-authors file, so even 'user name' is accepted.
> > ---
> > git-svn.perl | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/git-svn.perl b/git-svn.perl
> > index 01c3904..975075e 100755
> > --- a/git-svn.perl
> > +++ b/git-svn.perl
> > @@ -740,7 +740,7 @@ sub load_authors {
> > my $log = $cmd eq 'log';
> > while (<$authors>) {
> > chomp;
> > - next unless /^(\S+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
> > + next unless /^(\.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>
> Surely you mean the following:
>
> + next unless /^(.+?|\(no author\))\s*=\s*(.+?)\s*<(.+)>\s*$/;
>
> (No "\" before the ".") "\." matches a dot/period (.), while "."
> matches anything.Fwiw, with the regexp corrected:
Acked-by: Eric Wong <normalperson@yhbt.net>
--
Eric Wong