Re: [PATCH] fall back to mozilla's sha.h if openssl/sha.h is not available

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jul 14, 2007, 15:12 UTC
Message-ID: <20070714151231.GD2544@steel.home>
In-Reply-To: <20070714145013.GA14488@piper.oerlikon.madduck.net>

martin f krafft, Sat, Jul 14, 2007 16:50:13 +0200:

Show 7 quoted lines

> also sprach Alex Riesen <raa.lkml@gmail.com> [2007.07.14.1623 +0200]:
> > > This should possibly go to configure.ac, but maybe *also* to Makefile to make
> > 
> > Definitely. It should it least skip the test if NO_OPENSSL is already
> > defined.
> 
> Reading this as a yes, here is the patch adding this. ...

I was not clear. Read it as NO.

> My autotools knowledge is limited, but I might then look at adding
> the fall back to configure.ac too.

Some (me, for one) will consider it the only place where it should be

> Btw: I've done a lot of things wrong on this mailing list already,
> for which I'd like to apologise. Thanks to those who told me
> privately off my faux pas. I hope those won't be necessary anymore.

If I were you, I would have considered CPPFLAGS and CFLAGS and added a check if HAS_OPENSSL already set.

And BTW doesn't it strike you as a little bit odd that noone has done that in Makefile before you? Could that be because configure is considered the _right_ place for this kind of stuff?