Re: mtimes of working files

From: Eric Wong <normalperson@yhbt.net>
Date: Jul 12, 2007, 18:25 UTC
Message-ID: <20070712182502.GA24854@hand.yhbt.net>
In-Reply-To: <86myy122mm.fsf@blue.stonehenge.com>

"Randal L. Schwartz" <merlyn@stonehenge.com> wrote:

Show 10 quoted lines

> >>>>> "Eric" == Eric Wong <normalperson@yhbt.net> writes:
> 
> Eric> open FH, "git log -r --name-only --no-color --pretty=raw -z @ARGV |" or die $!;
> 
> This breaks needlessly on @ARGV names that contain spaces.  You want:
> 
>   open FH, "-|", qw(git log -r --name-only --no-color --pretty=raw -z), @ARGV or die $!;
> 
> But that sounds familiar.... I think there's a function somewhere included in
> the git distro that does this.  I'm old and senile though. :)

Yep, I added that @ARGV at the last second and didn't care enough to fix it. I didn't want to link this into the git build system so that it could find Git.pm, either.

So I'll just go with this 5.8-ism. I didn't really intend for that script to go anywhere, maybe somebody who wants it badly enough can make the ls-files call respect any path limiting intended in @ARGV but still allow revision ranges to be passed (my original intention of supporting @ARGV was only revision ranges).

-- 
Eric Wong