Re: [PATCH] Push code for transport library

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 8, 2007, 21:14 UTC
Message-ID: <20070708211418.GA4436@spearce.org>
In-Reply-To: <Pine.LNX.4.64.0707081608100.6977@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> wrote:

> This moves the code to call push backends into a library that can be
> extended to make matching fetch and push decisions based on the URL it
> gets, and which could be changed to have built-in implementations
> instead of calling external programs.

...

> +static const struct transport_ops git_transport = {
> +	.set_option = set_git_option,
> +	.push = git_transport_push
> +};

Interesting.

But can we please avoid that struct initialization syntax? I build Git with a C compiler that doesn't understand it. No, I can't upgrade the compiler. In the past we've largely been able to avoid using this feature of C99. If you look at the current codebase this would again become the first usage of the feature, as I have long since eliminated all of them.

-- 
Shawn.