Re: [PATCH] git-commit: don't add multiple Signed-off-by: from the same identity

From: Gerrit Pape <pape@smarden.org>
Date: Jul 8, 2007, 15:00 UTC
Message-ID: <20070708150055.7018.qmail@10e1f648410572.315fe32.mid.smarden.org>
In-Reply-To: <7vy7hte717.fsf@assigned-by-dhcp.cox.net>

On Fri, Jul 06, 2007 at 11:11:48AM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> If you are trying to avoid a run of Signed-off-by: lines like this:
> 
> 	Signed-off-by: Original Author <oa@example.com>
> 	Signed-off-by: First Reviewer <fr@example.com>
> 	Signed-off-by: Second Reviewer <sr@example.com>
> 	Signed-off-by: Original Author <oa@example.com>
> 	Signed-off-by: Subsystem Integrator <si@example.com>
> 
> It is not a bug.  If the last signed-off-by is not from
> yourself, your signed-off-by is added when you ask with "-s",

This is what the patch does, it only checks against the final line, sorry, the subject is incorrect. The behavior currently is

 $ ./git-commit -m foo foo
 Created commit 2fad03e: foo
  0 files changed, 0 insertions(+), 0 deletions(-)
  create mode 100644 foo
 $ EDITOR=cat ./git-commit --amend -s foo |head -n4
 foo

 Signed-off-by: Gerrit Pape <pape@smarden.org>

 $ EDITOR=cat ./git-commit --amend -s foo |head -n4
 foo

 Signed-off-by: Gerrit Pape <pape@smarden.org>
 Signed-off-by: Gerrit Pape <pape@smarden.org>
 $

with the patch, iff the last line already was the signoff to be added, it won't be added again.

Show 8 quoted lines

> We have deliberately excluded what your other patch tries to do
> for a reason.  Even though these lines are not digitally signed,
> the intent of adding a Signed-off-by: line with your name is
> that you are certifying its origin, according to the definition
> of DCO (see Documentation/SubmittingPatches).  This should be a
> conscious act from the signer's part, and making it automatic
> with a config variable that you set once and forget makes it
> much less meaningful.

Okay, to me personally it would be convenient, for the git repository I have no problem with, and want to simply singoff all commits, for other repos none.

Regards, Gerrit.