Re: git-apply{,mbox,patch} should default to --unidiff-zero

From: Adrian Bunk <bunk@stusta.de>
Date: Jul 6, 2007, 01:42 UTC
Message-ID: <20070706014222.GK3492@stusta.de>
In-Reply-To: <Pine.LNX.4.64.0707060217460.9789@racer.site>

On Fri, Jul 06, 2007 at 02:18:46AM +0100, Johannes Schindelin wrote:

> Hi,

Hi Johannes,

Show 7 quoted lines

> On Fri, 6 Jul 2007, Adrian Bunk wrote:
> 
> > git-apply{,mbox,patch} should default to doing --unidiff-zero:
> 
> But is that not dangerous? At least now the committer has some safeguard 
> against this kind of mistakes. Because you can easily introduce mistakes 
> that way.

you are saying "easily".

Did you ever actually run into such a problem?

You must do something like "diff -U0" or manually editing patches for creating such patches, and that's very unusual.

And although GNU patch (which has a much bigger userbase than git) applies such patches without any warning I don't remember having ever seen what you call "easily".

> Ciao,
> Dscho

cu Adrian

-- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed