Re: [PATCH] repack: don't report "Nothing new to pack." if -q is given

From: Peter Baumann <waste.manager@gmx.de>
Date: Jul 3, 2007, 18:19 UTC
Message-ID: <20070703181923.GE4580@xp.machine.xx>
In-Reply-To: <20070703084757.GA4694@lala>

On Tue, Jul 03, 2007 at 10:47:58AM +0200, Uwe Kleine-König wrote:

Show 23 quoted lines

> Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
> ---
> This patch is on top of maint.  For master and next you need
> s/name/names/.
> 
> Best regards
> Uwe
> 
>  git-repack.sh |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/git-repack.sh b/git-repack.sh
> index ddfa8b4..d980275 100755
> --- a/git-repack.sh
> +++ b/git-repack.sh
> @@ -65,7 +65,9 @@ args="$args $local $quiet $no_reuse_delta$extra"
>  name=$(git-pack-objects --non-empty --all --reflog $args </dev/null "$PACKTMP") ||
>  	exit 1
>  if [ -z "$name" ]; then
> -	echo Nothing new to pack.
> +	if test -q "$quiet"; then
> +		echo Nothing new to pack.
> +	fi

This looks wrong, especially as I can't find a '-q' in the manpage of "test". Perhaps you ment something like the following code, which is already used in the script:

	if test "$quiet" != '-q'; then
		echo ...
	fi

-Peter