git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: segfault during git-prune

From
APAndy Parkins <andyparkins@gmail.com>
Date
Jul 2, 2007, 13:25 UTC
Message-ID
<200707021425.38367.andyparkins@gmail.com>
In-Reply-To
<alpine.LFD.0.98.0707020441460.3323@woody.linux-foundation.org>
On Monday 2007 July 02, Linus Torvalds wrote:
> Just for clarity, I'd use "process_gitlink()" here (and it would probably
> be a good idea to use process_blob() on the blob we look up too), and the
> proper tab indentation, but yes, I think you're otherwise exactly right.

I've pushed it out as-is as a bug fix patch now; and will happilly make the above change on top. However, I've not understood what all the parameters are for in the process_XXXX() functions:

static void process_gitlink(const unsigned char *sha1,
			    struct object_array *p,
			    struct name_path *path,
			    const char *name)

the sha1 and name I can read out of the cache_entry structure, but I'm not sure about the object_array and name_path structures in the context of add_cache_refs().

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com
Previous: Linus TorvaldsNext: Linus Torvalds
Message 10 of 11 in “Bug: segfault during git-prune”
  1. Andy ParkinsJun 28, 2007
  2. Andy ParkinsJun 28, 2007
  3. Linus TorvaldsJun 28, 2007
  4. Linus TorvaldsJun 28, 2007
  5. Andy ParkinsJun 28, 2007
  6. Linus TorvaldsJun 28, 2007
  7. Andy ParkinsJun 29, 2007
  8. Andy ParkinsJul 2, 2007
  9. Linus TorvaldsJul 2, 2007
  10. Andy ParkinsJul 2, 2007
  11. Linus TorvaldsJul 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.