being nice to patch(1)
- From
- Andrew Morton <akpm@linux-foundation.org>
- Date
- Jul 2, 2007, 19:54 UTC
- Message-ID
- <20070702125450.28228edd.akpm@linux-foundation.org>
James's current git-scsi-misc has this commit in it:
commit a16efc1cbf0a9e5ea9f99ae98fb774b60d05c35b Author: Kars de Jong <jongk@linux-m68k.org> Date: Sun Jun 17 14:47:08 2007 +0200
[SCSI] 53c700: Amiga 4000T NCR53c710 SCSI
New driver for the Amiga 4000T built-in NCR53c710 SCSI controller, using the
53c700 SCSI core.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>When one pulls that diff out of git with `git-show' or whatever, it doesn't work - patch(1) has a heart attack over the "53c700":
|commit f98754960a9b25057ad5f249f877b3d6fab889ce |Author: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> |Date: Mon May 14 20:25:31 2007 +0900 | | [SCSI] hptiop: convert to use the data buffer accessors | | - remove the unnecessary map_single path. | | - convert to use the new accessors for the sg lists and the | parameters. | | Jens Axboe <jens.axboe@oracle.com> did the for_each_sg cleanup. | | Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> | Acked-by: HighPoint Linux Team <linux@highpoint-tech.com> | Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | |commit a16efc1cbf0a9e5ea9f99ae98fb774b60d05c35b |Author: Kars de Jong <jongk@linux-m68k.org> |Date: Sun Jun 17 14:47:08 2007 +0200 | | [SCSI] 53c700: Amiga 4000T NCR53c710 SCSI | | New driver for the Amiga 4000T built-in NCR53c710 SCSI controller, using the -------------------------- File to patch:
This I assume is because ^[ ]*<number>c<number> is a magic marker for contextual diffs.
So... if someone is feeling really, really, really bored one day, it would be nice to teach git to somehow escape such patch-magic-patterns in the changelog when emitting plain old patches.