Re: [PATCH] Don't fflush(stdout) when it's not helpful
- From
Frank Lichtenheld <frank@lichtenheld.de>
- Date
- Jun 29, 2007, 01:05 UTC
- Message-ID
- <20070629010507.GL12721@planck.djpig.de>
- In-Reply-To
- <20070628235319.GD29279@thunk.org>
On Thu, Jun 28, 2007 at 07:53:19PM -0400, Theodore Tso wrote:
> Good point. Here's a revised patch where GIT_FLUSH=0 and GIT_FLASH=1 > trumps any hueristics.
[...]
Show 7 quoted lines
> + else if (getenv("GIT_NEVER_FLUSH_STDOUT") ||
> + ((fstat(fileno(stdout), &st) == 0) &&
> + S_ISREG(st.st_mode)))
> + stdout_is_file = 1;
> + else
> + stdout_is_file = 0;
> + }Any particular reason why you still check for GIT_NEVER_FLUSH_STDOUT in addition to GIT_FLUSH?
Gruesse,
-- Frank Lichtenheld <frank@lichtenheld.de> www: http://www.djpig.de/