git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[StGIT PATCH 2/3] Disallow non-patch args to "stg show" (gna #8453).

From
Yann Dirson <ydirson@altern.org>
Date
Jun 28, 2007, 21:44 UTC
Message-ID
<20070628214410.26983.20341.stgit@gandelf.nowhere.earth>
In-Reply-To
<20070628214242.26983.99859.stgit@gandelf.nowhere.earth>

Git-core refs and patch@branch args were not allowed in the multiple-argument form of "stg show". For consistency we completely disallow them: git-core refs are available from git-show, and "stg show patch@branch" as "stg show patch -b branch".

Signed-off-by: Yann Dirson <ydirson@altern.org>
---
 stgit/commands/show.py |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/stgit/commands/show.py b/stgit/commands/show.py
index c59ac68..3bf4f20 100644
--- a/stgit/commands/show.py
+++ b/stgit/commands/show.py
@@ -55,12 +55,7 @@ def func(parser, options, args):
     elif len(args) == 0:
         patches = ['HEAD']
     else:
-        if len(args) == 1 and args[0].find('..') == -1 \
-               and not crt_series.patch_exists(args[0]):
-            # it might be just a commit id
-            patches = args
-        else:
-            patches = parse_patches(args, applied + unapplied, len(applied))
+        patches = parse_patches(args, applied + unapplied, len(applied))
 
     if options.diff_opts:
         diff_flags = options.diff_opts.split()
Previous: Yann DirsonNext: Yann Dirson
Message 3 of 4 in “cleanup "show" and friends”
  1. 0/3 cleanup "show" and friendsYann Dirson, Jun 28, 2007
  2. 1/3 Allow "git show --branch".Yann Dirson, Jun 28, 2007
  3. 2/3 Disallow non-patch args to "stg show" (gna #8453).Yann Dirson, Jun 28, 2007
  4. 3/3 Make hidden patches visible to various commands (notably log, show, pick).Yann Dirson, Jun 28, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.