Re: [PATCH] config: add support for --bool and --int while setting values

From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Jun 25, 2007, 16:14 UTC
Message-ID: <20070625161401.GW19725@planck.djpig.de>
In-Reply-To: <467FCBEA.906B14@eudaptics.com>

On Mon, Jun 25, 2007 at 04:06:34PM +0200, Johannes Sixt wrote:

Show 6 quoted lines

> Frank Lichtenheld wrote:
> > 
> > Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
> 
> Please excuse if I'm missing the big picture, but why do we need this
> change?

- Of course the user or script calling git-config can do the
  normalization and error checking, if they want to. But I would
  prefer to have it available in git-config.
- I would prefer that these options wouldn't be silently ignored,
  because that can be confusing (at least it is documented now, but
  still). So we should either using them or error out. I prefer the former.

Something that I forgot to mention in the previous mail: One real problem with the patch is that it expands the k,m,g suffixes for integer values. It probably shouldn't do that.

Gruesse,

-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/