Re: [RFC][PATCH] Fix assumption that git is installed in a standard place on the remote end ssh
- From
- Kevin Green <kevin.t.green@morganstanley.com>
- Date
- Jun 22, 2007, 01:30 UTC
- Message-ID
- <20070622013026.GY14298@menevado.ms.com>
- In-Reply-To
- <Pine.LNX.4.64.0706190114110.4059@racer.site>
On 06/18/07 20:16:47, Johannes Schindelin wrote:
Show 14 quoted lines
> Hi, > > On Fri, 15 Jun 2007, Kevin Green wrote: > > > I'm thinking I like the env var idea much more though. I can just > > export it in my shell and it works in both cases. > > And it completely breaks down when you have more than one remotes. Or when > you cd to another project with another remote. Or etc. IOW it is fragile. > > Clearly, the config approach is the only one which makes sense. This > information is so closely coupled to a specific remote that you should > store it right where you store all the other remote information, too. >
You're absolutely right. I agree, except that in _my_ environment git will be in a non-standard path but *always* consistently in the same place. I'm being greedy here. :)
The config approach is clearly the most versatile. The question I have is, is there a good reason not to provide the third option of setting env var? I suppose that in the more likely case this could cause more harm than good, i.e. maybe this is too specific for my use case.
Thanks
--Kevin