git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH]: tree-walk.h: Warning fix

From
LCLuiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Date
Jun 20, 2007, 02:11 UTC
Message-ID
<20070619231127.7ffe273b@gnut>

Code that is using libgit.a, and hence including GIT's headers, may get this warning:

""" ../tree-walk.h: In function 'tree_entry_len': ../tree-walk.h:25: warning: cast discards qualifiers from pointer target type ../tree-walk.h:25: warning: cast discards qualifiers from pointer target type """

This happens because the cast used in tree_entry_len() is discarding the const qualifier (thanks to Shawn Pearce by noticing this).

Signed-off-by: Luiz Fernando N. Capitulino <lcapitulino@gmail.com>
diff --git a/tree-walk.h b/tree-walk.h
index ee747ab..625198f 100644
--- a/tree-walk.h
+++ b/tree-walk.h
@@ -22,7 +22,7 @@ static inline const unsigned char *tree_entry_extract(struct tree_desc *desc, co
 
 static inline int tree_entry_len(const char *name, const unsigned char *sha1)
 {
-	return (char *)sha1 - (char *)name - 1;
+	return (const char *)sha1 - (const char *)name - 1;
 }
 
 void update_tree_entry(struct tree_desc *);
Next: Junio C Hamano
Message 1 of 3 in “: tree-walk.h: Warning fix”
  1. : tree-walk.h: Warning fixLuiz Fernando N. Capitulino, Jun 20, 2007
  2. Junio C HamanoJun 23, 2007
  3. Luiz Fernando N. CapitulinoJun 24, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.