git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: merging git-p4 into git/fastimport.git (second try)

From
Shawn O. Pearce <spearce@spearce.org>
Date
Jun 18, 2007, 23:00 UTC
Message-ID
<20070618230018.GA6143@spearce.org>
In-Reply-To
<200706190036.01950.simon@lst.de>
Simon Hausmann <simon@lst.de> wrote:
Show 5 quoted lines
> after reworking most of the really short commit logs and adding the missing 
> SOB lines I'd like to ask for consideration of merging git-p4 as part of 
> contrib/fastimport/ from
> 
> 	git://repo.or.cz/fast-export.git git-p4

Most of the commits look pretty good. The effort you have put into cleaning them up shows.

However, many of the oneline descriptions from Han-Wen Nienhuys are still really short and not very descriptive. They won't look very good in Junio's "What's in git.git". A few of yours are also pretty long winded for a typical oneline in git.git, but I'd rather have a descriptive-but-long oneline anytime over a short and undescriptive one.

So I'm seriously considering merging this at this point. I'm heading out to dinner and will look at it more again when I get back, but I think we should just bite the bullet and bring it into core Git.

-- 
Shawn.
Previous: Simon HausmannNext: Simon Hausmann
Message 2 of 4 in “merging git-p4 into git/fastimport.git (second try)”
  1. Simon HausmannJun 18, 2007
  2. Shawn O. PearceJun 18, 2007
  3. Simon HausmannJun 19, 2007
  4. Shawn O. PearceJun 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.