Re: What's cooking in git.git (topics)

From: Matthias Lederhofer <matled@gmx.net>
Date: Jun 18, 2007, 17:20 UTC
Message-ID: <20070618172044.GA1197@moooo.ath.cx>
In-Reply-To: <7vtztbbnsq.fsf@assigned-by-dhcp.pobox.com>

Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> * ei/worktree+filter (Wed Jun 6 09:16:56 2007 +0200)
>  - filter-branch: always export GIT_DIR if it is set
> * ml/worktree (Fri Jun 8 22:57:55 2007 +0200) 9 commits
>  - make git barf when an alias changes environment variables
>  - setup_git_directory: fix segfault if repository is found in cwd
>  - test GIT_WORK_TREE
>  - extend rev-parse test for --is-inside-work-tree
>  - Use new semantics of is_bare/inside_git_dir/inside_work_tree
>  - introduce GIT_WORK_TREE to specify the work tree
>  - test git rev-parse
>  - rev-parse: introduce --is-bare-repository
>  - rev-parse: document --is-inside-git-dir
> 
> Undecided.  Some people would want to have a way to have GIT_DIR
> point at somewhere unusual and still want to work from within a
> subdirectory, which is probably a valid thing to support.  This
> is not something I would use myself, so I am mostly worried
> about the impact these changes may have on people who do not use
> this feature.

The only problem I know of up to now seems the one which happened with git-filter-branch: if GIT_DIR is set and GIT_WORK_TREE/core.worktree is set the specified working tree is used instead of cwd.

So for users not using GIT_WORK_TREE/core.worktree there should be no problem. There might be problems if someone distributes scripts for git which expect the old behaviour and the user specified the worktree. OTOH the fix is to export GIT_WORK_TREE=. which does not break the script for older versions of git versions and is quite short (i.e. should not require any restructuring of the script).