Re: [PATCH] Introduce file with the common default build-time items.

From: Eygene Ryabinkin <rea-git@codelabs.ru>
Date: Jun 14, 2007, 09:56 UTC
Message-ID: <20070614095654.GT86872@void.codelabs.ru>
In-Reply-To: <20070614043633.GV6073@spearce.org>

Shawn, good day.

Thu, Jun 14, 2007 at 12:36:33AM -0400, Shawn O. Pearce wrote:

Show 22 quoted lines

> Eygene Ryabinkin <rea-git@codelabs.ru> wrote:
> > Words 'wish' and 'tclsh' are scattered across at least three files,
> > but they are tied to the same entities.  To ease the maintenance
> > and remove errors, these configuration items were gathered into the
> > separate file named 'common-make-vars.def'.
> ...
> > diff --git a/git-gui/Makefile b/git-gui/Makefile
> > index 3de0de1..654641a 100644
> > --- a/git-gui/Makefile
> > +++ b/git-gui/Makefile
> > @@ -6,6 +6,8 @@ all::
> >  GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
> >  	@$(SHELL_PATH) ./GIT-VERSION-GEN
> >  -include GIT-VERSION-FILE
> > +# Default values
> > +-include ../common-make-vars.def
> 
> A good idea to try and make these all common, but you cannot do this,
> or at least this part of the patch.
> 
> The git-gui subdirectory of git.git is actually its own project,
> maintained in its own Git repository.

OK, but then may be it will be logical to put Tcl/Tk-related variables to the git-gui/common-make-vars.def? I am a little worried about this, because gitk is the part of the git.git and it should get the variables too. The drawback here is if you will update your git-gui repo, then git.git will need to wait for your import to get the changes in the variables. And this will seriously couple git.git and git-gui, though I don't know if it is good or bad.

Any ideas?

-- 
Eygene