Re: Mail after commit

From: Andy Parkins <andyparkins@gmail.com>
Date: Jun 13, 2007, 15:10 UTC
Message-ID: <200706131610.42779.andyparkins@gmail.com>
In-Reply-To: <20070613142516.GE22027@lug-owl.de>

On Wednesday 2007 June 13, Jan-Benedict Glaw wrote:

Show 5 quoted lines

> > I think most people setup gitweb, and follow its rss feed. Not exacty
> > the same, I know, but quite useful.
>
> Erm, no, not really.  Emailing the patches is *quite* useful when
> there's a dedicated review team.

As an aside - I find it better to send announce emails on git-push rather than git-commit. If you send an email on git-commit, then your working repository becomes a whole lot less useful.

For example I often do:

 git commit -a -m "Shelve what I'm doing right now"
 git checkout -b temporary-branch HEAD^^^
 vim fix-bug-that-I-never-want-anyone-to-see
 git checkout master
 git rebase temporary-branch
 git branch -d temporary-branch
 git reset HEAD^

Obviously this only works for commits I haven't pushed yet, but it's very useful to be able to do - usually I need it because I missed a git-add of a file out of a commit and didn't notice for a while.

Once I'm happy with my local history, then I git-push to the shared repository and an email is generated to let other members of the team know I've done something - they can then git-fetch and review if they feel like it.

To me, sending an email every commit would be like sending an email every time I pressed "save" in the editor.

Andy

-- 
Dr Andy Parkins, M Eng (hons), MIET
andyparkins@gmail.com