Re: [PATCH] Introduce light weight commit annotations
- From
Johan Herland <johan@herland.net>
- Date
- Jun 10, 2007, 13:14 UTC
- Message-ID
- <200706101514.14954.johan@herland.net>
- In-Reply-To
- <Pine.LNX.4.64.0706091854330.4059@racer.site>
On Saturday 09 June 2007, Johannes Schindelin wrote:
Show 7 quoted lines
> With the provided script, edit-commit-annotations, you can add > after-the-fact annotations to commits, which will be shown by > the log if the config variable core.showannotations is set. > > The annotations are tracked in a new ref, refs/annotations/commits, > in the same fan-out style as .git/objects/??/*, only that they only > exist in the object database now.
Very interesting. I have to say that after having played around with it a couple of minutes, I really like it. Needs some polishing here and there (i.e. cleaning up the COMMIT_ANNOTATION.NNNN* files), but it is a very good proof-of-concept.
> I have the hunch that this will be relatively fast and scalable, > since the tree objects are sorted by name (the name being the > object name of the to-be-annotated commit).
I think I agree with your hunch, although I initially thought that your solution was a bit heavy on the number of objects created. But, hey, git is _designed_ to handle massive amounts of objects. :)
Show 13 quoted lines
> diff --git a/config.c b/config.c
> index 58d3ed5..34db9b2 100644
> --- a/config.c
> +++ b/config.c
> @@ -356,6 +356,11 @@ int git_default_config(const char *var, const char *value)
> return 0;
> }
>
> + if (!strcmp(var, "core.showannotaions")) {
> + show_commit_annotations = git_config_bool(var, value);
> + return 0;
> + }
> +Small typo here. "core.showannotaions" should be "core.showannotations", I guess.
...Johan
-- Johan Herland, <johan@herland.net> www.herland.net