Re: [PATCH] gitweb: change filename/directory name of snapshots

From: Petr Baudis <pasky@suse.cz>
Date: Jun 8, 2007, 17:18 UTC
Message-ID: <20070608171811.GX4489@pasky.or.cz>
In-Reply-To: <7v4pliltuv.fsf@assigned-by-dhcp.cox.net>

On Fri, Jun 08, 2007 at 10:43:04AM CEST, Junio C Hamano wrote:

Show 17 quoted lines

> Matthias Lederhofer <matled@gmx.net> writes:
> 
> > /.git or .git is removed from the project name and the
> > basename of the remaining path is used as the beginning of
> > the filename and as the directory in the archive.
> >
> > The regexp will actually not strip off /.git or .git if there
> > wouldn't be anything left after removing it.
> >
> > Currently the full project name is used as directory in the
> > archive and the basename is used as filename.  For example a
> > repository named foo/bar/.git will have a archive named
> > .git-<version>.* and extract to foo/bar/.git.  With this patch
> > the file is named bar-<version>.* and extracts to bar.
> 
> Makes sense to me for "foo/bar/.git", but I am not sure if we
> would want to do this to "foo/bar.git".  Opinions?

I wouldn't personally really mind getting rid of the .git suffix in both cases. Yes, we are used to seeing the ".git" in the name, but I can't think of any other reasons not to chop it off.

Having the .git in the archive name might be even more confusing since there is a pseudo-convention (that I'm not sure anyone except me follows, so maybe not :) that repositories have .git in the name while working trees don't, and that tarball contains a working tree.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Ever try. Ever fail. No matter. // Try again. Fail again. Fail better.
		-- Samuel Beckett