Re: [PATCH] Use git-tag in git-cvsimport

From: Elvis Pranskevichus <elprans@gmail.com>
Date: Jun 4, 2007, 23:55 UTC
Message-ID: <200706041955.52779.elprans@gmail.com>
In-Reply-To: <7v1wgto2mh.fsf@assigned-by-dhcp.cox.net>

> hoi :)

Hi =)

Show 5 quoted lines

> On Sun, Jun 03, 2007 at 05:01:03PM -0700, Junio C Hamano wrote:
> > Martin Waitz <tali@admingilde.org> writes:
> > > but lightweight tags are not fetched by default.
> > 
> > Are you sure about that?

> not any more now that you questioned it ;-)

Last time I checked, unannotated tags are git-cloned and git-fetched just fine. I'm not sure about the exact definition and behaviour of lightweight tags, though.

CVS just doesn't attach any valuable info to the tags, it's just a point in time.

> But at least there is a hook script which refuses to receive
> un-annotated tags and I always considered those tags to be temporary
> tags in the local repository.

Well, there's no mention about that in the docs. And I don't think that the notion of git losing valid objects along the way is the good one =)

Anyways, the patch wasn't about the tag type change. As I mentioned it's just a side effect. The main point is to fix the cvsimport tag breakage. I've tested that change on a few big (and messy) CVS repos, and it works just fine.

Cheers,

-- 
                 Elvis