Re: [PATCH] Create a new manpage for the gitignore format, and reference it elsewhere

From: Frank Lichtenheld <djpig@debian.org>
Date: Jun 1, 2007, 23:47 UTC
Message-ID: <20070601234710.GW3242@planck.djpig.de>
In-Reply-To: <46609BC4.9000508@freedesktop.org>

Cool :)

Some remarks below.

On Fri, Jun 01, 2007 at 03:20:52PM -0700, Josh Triplett wrote:

> Signed-off-by: Josh Triplett <josh@freedesktop.org>
> Signed-off-by: Josh Triplett <josh@freedesktop.org>

:) (Wanted to make some funny remark, but its too late here to be funny in a foreign language...)

>  Documentation
>  --------------
> -Documentation by David Greaves, Junio C Hamano and the git-list <git@vger.kernel.org>.
> +Documentation by David Greaves, Junio C Hamano, Josh Triplett, and the git-list <git@vger.kernel.org>.

No offence, but adding your name here for removing content? ;)

> +Some git plumbing tools, such as git-ls-files(1) and
> +git-read-tree(1), read `gitignore` patterns specified by
> +command-line options, or from files specified by command-line
> +options.

Missing gitlink:

Also I don't like the paragraph. It should probably mention that these programs actually implement the behaviour described, that they aren't hardcoded to the mentioned filenames and that all git porcelain just happens to call them with them.

But, as said, too late here for proper English ;)

Show 6 quoted lines

> +Patterns have the following format:
> +
> + - A blank line matches no files, so it can serve as a separator
> +   for readability.
> +
> + - A line starting with #

Is here missing something?

Show 7 quoted lines

> + - Otherwise, git treats the pattern as a shell glob suitable
> +   for consumption by fnmatch(3) with the FNM_PATHNAME flag: any
> +   slash in the pattern must match a slash in the pathname.  For
> +   example, "Documentation/\*.html" matches
> +   "Documentation/git.html" but not "ppc/ppc.html".  A leading
> +   slash matches the beginning of the pathname; for example,
> +   "/*.c" matches "cat-file.c" but not "mozilla-sha1/sha1.c".

I realise this is copy&paste but shouldn't that read: "Documentation/\*.html" matches "Documentation/git.html" but not "Documentation/ppc/ppc.html" ?

> +Documentation
> +-------------
> +Documentation by Josh Triplett.

No offence again, but given the amount of copy&paste, maybe the names from git-ls-files should also be added here.

Gruesse,

-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/