Re: [PATCH] fix memory leak in parse_object when check_sha1_signature fails

From

Shawn O. Pearce <spearce@spearce.org>

Date

May 25, 2007, 02:09 UTC

Message-ID

<20070525020939.GT28023@spearce.org>

In-Reply-To

<1b46aba20705241846u615785eeh7c3ebeaf840b2180@mail.gmail.com>

Carlos Rica <jasampler@gmail.com> wrote:

> When check_sha1_signature fails, program is not terminated:
> it prints an error message and returns NULL, so the
> buffer returned by read_sha1_file should be freed before.

...

> 		if (check_sha1_signature(sha1, buffer, size, typename(type)) 
> 		< 0) {

...

-- 
Shawn.