Re: [PATCH] Split packs from git-repack should have descending timestamps

From: Shawn O. Pearce <spearce@spearce.org>
Date: May 25, 2007, 00:46 UTC
Message-ID: <20070525004610.GP28023@spearce.org>
In-Reply-To: <465612CE.4080605@gmail.com>

Dana How <danahow@gmail.com> wrote:

Show 12 quoted lines

> 
> If git-repack produces multiple split packs because
> --max-pack-size was in effect,  the first pack written
> should have the latest timestamp because:
> (1) sha1_file.c:rearrange_packed_git() puts more recent
>     pack files at the beginning of the search list;  and
> (2) the most recent objects are written out first
>     while packing.
> 
> This is based on next rather than master to avoid merge
> conflicts with changes already in git-repack.sh due to
> the --max-pack-size patchset.

Ack. Given our mtime based sorting routine, even without your recent patch to improve it, I think we definately want this type of behavior built into git-repack.sh. Good follow-on to your --max-pack-size series.

-- 
Shawn.