Re: [PATCH] revert/cherry-pick: allow the last parameter to be -h

From: Jonas Fonseca <fonseca@diku.dk>
Date: May 23, 2007, 05:31 UTC
Message-ID: <20070523053110.GA23971@diku.dk>
In-Reply-To: <7vwsz07b10.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote Tue, May 22, 2007:

Show 20 quoted lines

> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > Jonas Fonseca, Tue, May 22, 2007 23:29:45 +0200:
> >> +	if (!strcmp(arg, "-h"))
> >> +		usage(usage_str);
> >
> >     $ git rev-list --usage
> >     usage: git-rev-list [OPTION] <commit-id>... [ -- paths... ]
> >       limiting output:
> > 	--max-count=nr
> > 	--max-age=epoch
> >     ...
> >
> > Why should cherry-pick be different?
> 
> Good question.  FYI
> 
> 	$ git rev-list --huh?
> 
> works equally well ;-)

Because it is different?

   $ git revert --why-must-it-be-so-hard-to-learn-git-sometimes
   fatal: Cannot find '--why-must-it-be-so-hard-to-learn-git-sometimes'

Because, contrary to git-rev-list, git-revert/cherry-pick is considered part of the porcelain? Because asking that question to every small UI improvement is not very useful?

And yes I could spell out '--help', but it just seems weird that I need to know the calling convention of git-revert (_and_ git-cherry-pick for that matter) in order to get the usage string, because that was what I wanted to know in the first place. Anyway, if you don't like it, please just drop the patch. :)

-- 
Jonas Fonseca