git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rename dirlink to gitlink.

From
Martin Waitz <tali@admingilde.org>
Date
May 22, 2007, 05:59 UTC
Message-ID
<20070522055939.GG5412@admingilde.org>
In-Reply-To
<7vodkdbvmk.fsf@assigned-by-dhcp.cox.net>
hoi :)
On Mon, May 21, 2007 at 04:32:51PM -0700, Junio C Hamano wrote:
> As an internal symbol, S_IFDIRLNK makes _much_ more sense than
> S_IFGITLINK, exactly because it is a mixture of S_IFDIR and
> S_IFLNK.

But then we also should be consequent and rename the entire low-level plumbing to dirlink. I don't see a reason to keep both.

For me the S_ macro names are about the file type which is represented by them. The fact that dirlinks/gitlinks are represented as DIR + LNK is nice but not so important that we have to name the macro that way.

-- 
Martin Waitz
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 7 in “rename dirlink to gitlink.”
  1. rename dirlink to gitlink.Martin Waitz, May 21, 2007
  2. Torgil SvenssonMay 21, 2007
  3. Junio C HamanoMay 21, 2007
  4. Martin WaitzMay 22, 2007
  5. Junio C HamanoMay 22, 2007
  6. rename gitlink to dirlink.Martin Waitz, May 22, 2007
  7. Petr BaudisMay 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.