Git string manipulation functions wrong?

Hi,

I got this forwarded from a friend who is subscribed to the Dovecot mailing lists (dovecot is a pop3/imap server).

  http://www.dovecot.org/list/dovecot/2007-May/022853.html
  http://www.dovecot.org/list/dovecot/2007-May/022856.html

The Dovecot author claims there are "basic string manipulation errors" in the git code and that's a reason for him not to use git.

I can see his problem with *snprintf() functions in the case where the amount of output is larger than the buffer size: *snprintf() will return the number of characters written if there would have been enough space to write them, which will lead to problems with code like "len += snprintf(buf, max, bla, ...)". I don't see his problems with strncpy(), though.

Erik