git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Use stringbuf to clean up some string handling code.

From
Alex Riesen <raa.lkml@gmail.com>
Date
May 20, 2007, 09:56 UTC
Message-ID
<20070520095623.GA3106@steel.home>
In-Reply-To
<1179627942.32181.1288.camel@hurina>
Timo Sirainen, Sun, May 20, 2007 04:25:42 +0200:
> ---
>  commit.c      |   30 +++++++++++++-----------------
>  local-fetch.c |   34 ++++++++++++++++------------------
>  2 files changed, 29 insertions(+), 35 deletions(-)
I find it hard to believe that it actually was a cleanup.

It is a nicer code, but... it is bigger, heavier on stack, and it does not actually fix anything.

In my experience, such changes are seldom worth the effort. It may be a nice code (and I actually like str.[hc]), but its use _must_ be justified. I.e. it must simplify a complex formatting routine, or fix a bug, which otherwise would be too hard or ugly to fix. It is definitely not the case in this patch.

Previous: Timo SirainenNext: Junio C Hamano
Message 2 of 4 in “Use stringbuf to clean up some string handling code.”
  1. 3/3 Use stringbuf to clean up some string handling code.Timo Sirainen, May 20, 2007
  2. Alex RiesenMay 20, 2007
  3. Junio C HamanoMay 20, 2007
  4. Timo SirainenMay 20, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.