git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git-svn dcommit fails (connection closed unexpectedly)

From
EWEric Wong <normalperson@yhbt.net>
Date
May 19, 2007, 06:14 UTC
Message-ID
<20070519061422.GA17528@muzzle>
In-Reply-To
<vpqtzuf46k9.fsf@bauges.imag.fr>
Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
Show 29 quoted lines
> "Lars Hjemli" <lh@elementstorage.no> writes:
> 
> > Is this happening if you dcommit a file in a new directory?
> 
> That's it indeed.
> 
> The attached script seems to reproducibly trigger the problem on my
> box:
> 
> $ ../git-svn-test.sh
> Checked out revision 0.
> A         file
> Adding         file
> Transmitting file data .
> Committed revision 1.
> Initialized empty Git repository in .git/
> moy@localhost's password: 
>         A       file
> r1 = 4357177f2d927931d31c8c49c0237561648001a7 (git-svn)
> 
> Checked out HEAD:
>   svn+ssh://localhost//home/moy/tmp/test/test.26377/svnrepo r1
> Created commit aa2db5a: newdir
>  1 files changed, 1 insertions(+), 0 deletions(-)
>  create mode 100644 newdir/newfile
> moy@localhost's password: 
>         A       newdir/newfile
> Network connection closed unexpectedly: Connection closed unexpectedly at /home/moy/bin/local/verimag/git-svn line 405
> $

Thanks to your script I can reproduce it. svnserve (not git-svn) is segfaulting on me...

Show 31 quoted lines
> #! /bin/sh
> 
> mkdir test.$$
> cd test.$$
> 
> svnadmin create svnrepo
> 
> svn co file://$PWD/svnrepo svnco
> 
> cd svnco
> echo content > file
> svn add file
> svn commit -m "added file"
> cd ../
> 
> # This triggers the bug.
> git-svn clone svn+ssh://localhost/$PWD/svnrepo git-svn-co
> 
> # while this doesn't
> # git-svn clone file://localhost/$PWD/svnrepo git-svn-co
> 
> cd git-svn-co
> 
> mkdir newdir
> echo othercontent > newdir/newfile
> 
> git add newdir/newfile
> 
> git commit -m "newdir"
> 
> git-svn dcommit

Thanks. I didn't realize entirely new directories (and not empty directories in svn but git thought were new) were what was causing things to break.

-- 
Eric Wong
Previous: Matthieu MoyNext: Eric Wong
Message 6 of 18 in “[BUG] git-svn dcommit fails (connection closed unexpectedly)”
  1. Matthieu MoyMay 11, 2007
  2. Lars HjemliMay 11, 2007
  3. Lars HjemliMay 11, 2007
  4. Matthieu MoyMay 11, 2007
  5. Matthieu MoyMay 14, 2007
  6. Eric WongMay 19, 2007
  7. git-svn: avoid crashing svnserve when creating new directoriesEric Wong, May 19, 2007
  8. Matthieu MoyMay 19, 2007
  9. Eric WongMay 19, 2007
  10. Matthieu MoyMay 19, 2007
  11. Eric WongMay 13, 2007
  12. Martin EisenhardtMay 13, 2007
  13. Karl HasselströmMay 13, 2007
  14. Eric WongMay 13, 2007
  15. Eric WongMay 14, 2007
  16. Linus TorvaldsMay 14, 2007
  17. Matthieu MoyMay 14, 2007
  18. Matthieu MoyMay 14, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.